Skip to content

Conversation

@vincetran
Copy link
Member

@vincetran vincetran commented Jul 30, 2024

  • PR title and description conform to Pull Request guidelines.

Issue #, if available: N/A

Description of changes: This adds some more attributes that we get from the backend to the data class that we send to the UI component. This will allow the Liveness UI component to not use hard coded values and use the values retrieved from backend.

How did you test these changes? Unit tests passed and verified the changes works on both the no light build and is backwards compatible without the no light changes.

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vincetran vincetran marked this pull request as ready for review September 19, 2024 22:25
@vincetran vincetran requested a review from a team as a code owner September 19, 2024 22:25
@vincetran vincetran merged commit e5b6db1 into feat/no-light-sku Sep 20, 2024
1 check passed
@vincetran vincetran deleted the liveness-no-light-sku-support branch September 20, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants